hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14824) HBaseAdmin.mergeRegions should use full region names instead of encoded region names
Date Tue, 17 Nov 2015 20:26:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009430#comment-15009430
] 

Hadoop QA commented on HBASE-14824:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12772774/HBASE-14824-v1.patch
  against master branch at commit db42fc64f1e54ab8b47799eae7920f7298a5a406.
  ATTACHMENT ID: 12772774

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16551//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16551//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16551//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16551//console

This message is automatically generated.

> HBaseAdmin.mergeRegions should use full region names instead of encoded region names
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-14824
>                 URL: https://issues.apache.org/jira/browse/HBASE-14824
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Eungsop Yoo
>            Priority: Minor
>         Attachments: HBASE-14824-v1.patch, HBASE-14824.patch
>
>
> HBaseAdmin.mergeRegions() calls HBaseAdmin.getRegion() internally. HBaseAdmin.getRegion()
requires the full region name. So MetaTableAccessor.getRegion always returns null and this
causes one more meta table scan.
> {code}
>   Pair<HRegionInfo, ServerName> getRegion(final byte[] regionName) throws IOException
{
>     if (regionName == null) {
>       throw new IllegalArgumentException("Pass a table name or region name");
>     }
>     Pair<HRegionInfo, ServerName> pair =
>       MetaTableAccessor.getRegion(connection, regionName);
>     if (pair == null) {
> {code}
> I suppose to use full region names instead of encoded region names in HBaseAdmin.mergeRegions().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message