hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliott Clark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14811) HBaseInterClusterReplicationEndpoint retry logic is broken
Date Fri, 13 Nov 2015 21:07:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004717#comment-15004717
] 

Elliott Clark commented on HBASE-14811:
---------------------------------------

This is critical at least.

> HBaseInterClusterReplicationEndpoint retry logic is broken
> ----------------------------------------------------------
>
>                 Key: HBASE-14811
>                 URL: https://issues.apache.org/jira/browse/HBASE-14811
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 2.0.0, 1.2.0, 1.2.1
>            Reporter: Ashu Pachauri
>            Assignee: Ashu Pachauri
>            Priority: Critical
>
> In HBaseInterClusterReplicationEndpoint, we do something like this:
> {code}
> entryLists.remove(f.get());
> {code}
> where f.get() returns an ordinal number which represents the index of the element in
the entryLists that just succeeded replicating. We remove these entries because we want to
retry with remaining elements in the list in case of a failure. Since entryLists is an ArrayList,
the subsequent elements are shifted left in case we remove an element. This breaks the intended
functionality. The fix is to reverse sort the ordinals and then perform the deletion in one
go.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message