hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Marc Spaggiari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner
Date Tue, 17 Nov 2015 16:03:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008889#comment-15008889
] 

Jean-Marc Spaggiari commented on HBASE-14803:
---------------------------------------------

Indeed. Goal is to limit the number of messages logged by this class overall when turning
on debug mode on heavy scan tests. We do not want to keep one counter per region. That will
just create to many non-required counters. Here we just print that we are skipping some messages
and wait a bit before login again.

Like in the example copied from above
{quote}
2015-11-16 09:06:15,347 DEBUG [] r.SFS(479): d0a0169a565f442d9ed33f730f651503 skipped because
of Bloom Filter.
2015-11-16 09:06:15,347 DEBUG [] r.SFS(479): 78a1ffc4559c4691a849e284ce6f36d9 skipped because
of Bloom Filter.
2015-11-16 09:06:15,347 DEBUG [] r.SFS(479): d5ea38b1fb9041598eac8db5c5dba954 skipped because
of Bloom Filter.
2015-11-16 09:06:15,347 DEBUG [] r.SFS(479): c88d318f87494de5b758d5fc205b9156 skipped because
of Bloom Filter.
2015-11-16 09:06:15,347 DEBUG [] r.SFS(479): d6903214874542baad7681888eee57eb skipped because
of Bloom Filter.
2015-11-16 09:06:15,347 DEBUG [] r.SFS(479): 4fa83becd20f45859fcda7c4457b7f6a skipped because
of Bloom Filter.
2015-11-16 09:06:15,347 DEBUG [] r.SFS(479): 4f9d6165a4944aa5ab4afc0b22d564d3 skipped because
of Bloom Filter.
2015-11-16 09:06:15,347 DEBUG [] r.SFS(479): 58d8fdf501ae4138ad8530d0d28e2b9b skipped because
of Bloom Filter.
2015-11-16 09:06:15,347 DEBUG [] r.SFS(479): 5dedfb8908494ae5b60e6aa1c8b1b7ad skipped because
of Bloom Filter.
2015-11-16 09:06:15,347 DEBUG [] r.SFS(479): 7486989f4b574f0ba26534ff2d01b2e8 skipped because
of Bloom Filter.
2015-11-16 09:06:15,348 DEBUG [] r.SFS(441): To many messages logged. Skipping new messages.
{quote}
As you can see it's almost always a different store file, etc. We just want to reduce the
display, what ever ScanFileScanner it is on this RS.

Keep in mind that this is debug information only. We are not saying "This specific ScanFileScanner
here logged to many lines". Just that ScanFileScanner in general logged to many.

So I don't think we should have one counter per instance. But here again, it's just 7 bytes
to remove on 2 lines if we think we prefer it differently. But then on the tests side we might
still create many of them and log to much. This will have to be tested.

> Add some debug logs to StoreFileScanner
> ---------------------------------------
>
>                 Key: HBASE-14803
>                 URL: https://issues.apache.org/jira/browse/HBASE-14803
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>              Labels: beginner
>             Fix For: 1.2.0
>
>         Attachments: HBASE-14803.v0-trunk.patch, HBASE-14803.v1-trunk.patch, HBASE-14803.v2-trunk.patch,
HBASE-14803.v3-trunk.patch, HBASE-14803.v4-trunk.patch, HBASE-14803.v4-trunk.patch, HBASE-14803.v5-trunk.patch
>
>
> To validate some behaviors I had to add some logs into StoreFileScanner.
> I think it can be interesting for other people looking for debuging. So sharing the modifications
here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message