hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Marc Spaggiari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner
Date Tue, 17 Nov 2015 15:45:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008860#comment-15008860

Jean-Marc Spaggiari commented on HBASE-14803:

I was hesitant about the AtomicLong. It creates 2 other objects to guarantee atomicity. But
here, we don't really care about atomicity. If we display 11 lines of logs instead of 10 because
they have been a conflict, it doesn't really matters. Also, this is only when doing scans
for the same file at the same time and both skip it at the exact same time. Chances for this
to occurs are very small. That's why I went with long instead of AtomicLong.

Now, if we want AtomicLong instead, it's really not a big change ;) I can do that. We just
need to decide on what we prefer.... (And at the same time I will fix "To" into "Too"...)

> Add some debug logs to StoreFileScanner
> ---------------------------------------
>                 Key: HBASE-14803
>                 URL: https://issues.apache.org/jira/browse/HBASE-14803
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>              Labels: beginner
>             Fix For: 1.2.0
>         Attachments: HBASE-14803.v0-trunk.patch, HBASE-14803.v1-trunk.patch, HBASE-14803.v2-trunk.patch,
HBASE-14803.v3-trunk.patch, HBASE-14803.v4-trunk.patch, HBASE-14803.v4-trunk.patch, HBASE-14803.v5-trunk.patch
> To validate some behaviors I had to add some logs into StoreFileScanner.
> I think it can be interesting for other people looking for debuging. So sharing the modifications

This message was sent by Atlassian JIRA

View raw message