hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Marc Spaggiari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14803) Add some debug logs to StoreFileScanner
Date Sun, 15 Nov 2015 23:50:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006101#comment-15006101
] 

Jean-Marc Spaggiari commented on HBASE-14803:
---------------------------------------------

This error doesn't really make sense...

I ran it locally:
{quote}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed
in 8.0
Running org.apache.hadoop.hbase.regionserver.TestStoreFile
Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.737 sec - in org.apache.hadoop.hbase.regionserver.TestStoreFile

Results :

Tests run: 13, Failures: 0, Errors: 0, Skipped: 0
{quote}

Also, line 483 is:
{code}
        if (reader.getHFileReader() != null) {
{code}

However, reader can not be null there...
{code}
    if (!reader.passesTimerangeFilter(timeRange, oldestUnexpiredTS)) {
      if (LOG.isDebugEnabled()) {
        if (reader.getHFileReader() != null) {
{code}
Else it will have crashed sooner, and this reader.passesTimerangeFilter was already there
in the previous code. So nothing new, and impossible for reader to be null. Sound like it
took the previous version... I will cancel and push the one with the fixed tab and see the
result...


> Add some debug logs to StoreFileScanner
> ---------------------------------------
>
>                 Key: HBASE-14803
>                 URL: https://issues.apache.org/jira/browse/HBASE-14803
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>              Labels: beginner
>             Fix For: 1.2.0
>
>         Attachments: HBASE-14803.v0-trunk.patch, HBASE-14803.v1-trunk.patch, HBASE-14803.v2-trunk.patch,
HBASE-14803.v3-trunk.patch
>
>
> To validate some behaviors I had to add some logs into StoreFileScanner.
> I think it can be interesting for other people looking for debuging. So sharing the modifications
here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message