hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Youngjoon Kim (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-14784) Port conflict is not resolved in HBaseTestingUtility.randomFreePort()
Date Sat, 07 Nov 2015 00:24:11 GMT
Youngjoon Kim created HBASE-14784:
-------------------------------------

             Summary: Port conflict is not resolved in HBaseTestingUtility.randomFreePort()
                 Key: HBASE-14784
                 URL: https://issues.apache.org/jira/browse/HBASE-14784
             Project: HBase
          Issue Type: Bug
          Components: test
    Affects Versions: 1.1.2
            Reporter: Youngjoon Kim
            Assignee: Youngjoon Kim
            Priority: Minor


If takenRandomPorts.contains(port) == true, it means port conflict, so randomFreePort() should
rerun the loop. But continue statement leads to exit the loop, because port != 0.

{code:title=hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java}
public static int randomFreePort() {
  int port = 0; 
  do { 
    port = randomPort();
    if (takenRandomPorts.contains(port)) {
      continue;
    }    
    takenRandomPorts.add(port);

    ...

  } while (port == 0);
  return port;
}
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message