hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14784) Port conflict is not resolved in HBaseTestingUtility.randomFreePort()
Date Tue, 10 Nov 2015 19:55:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999215#comment-14999215
] 

stack commented on HBASE-14784:
-------------------------------

Nice test. Thank you [~y0un5]. I pushed the test to master branch only.  Let me reopen this
issue here so it runs hadoopqa just to be safe. Thanks.

> Port conflict is not resolved in HBaseTestingUtility.randomFreePort()
> ---------------------------------------------------------------------
>
>                 Key: HBASE-14784
>                 URL: https://issues.apache.org/jira/browse/HBASE-14784
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 1.1.2
>            Reporter: Youngjoon Kim
>            Assignee: Youngjoon Kim
>            Priority: Minor
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-14784.patch, HBASE-14784_Test.patch
>
>
> If takenRandomPorts.contains(port) == true, it means port conflict, so randomFreePort()
should rerun the loop. But continue statement leads to exit the loop, because port != 0.
> {code:title=hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java}
> public static int randomFreePort() {
>   int port = 0; 
>   do { 
>     port = randomPort();
>     if (takenRandomPorts.contains(port)) {
>       continue;
>     }    
>     takenRandomPorts.add(port);
>     ...
>   } while (port == 0);
>   return port;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message