hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14769) Remove unused functions and duplicate javadocs from HBaseAdmin
Date Tue, 24 Nov 2015 22:52:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025618#comment-15025618
] 

Appy commented on HBASE-14769:
------------------------------

Confirmed that they are being inherited.

{quote}
  /**
   * {@inheritDoc}
   * This receives puts *and* deletes.
   */
  @Override
  public MatchCode checkColumn(Cell cell, byte type) throws IOException {
    return MatchCode.INCLUDE;
  }
{quote}
Generates this
http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/regionserver/ScanWildcardColumnTracker.html#checkColumn(org.apache.hadoop.hbase.Cell,%20byte)

> Remove unused functions and duplicate javadocs from HBaseAdmin 
> ---------------------------------------------------------------
>
>                 Key: HBASE-14769
>                 URL: https://issues.apache.org/jira/browse/HBASE-14769
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14769-master-v2.patch, HBASE-14769-master-v3.patch, HBASE-14769-master-v4.patch,
HBASE-14769-master.patch
>
>
> HBaseAdmin is marked private, so removing the functions not being used anywhere.
> Also, the javadocs of overridden functions are same as corresponding ones in Admin.java.
Since javadocs are automatically inherited from the interface class, we can remove these redundant
100s of lines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message