hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14750) HBaseConfiguration.create() doesn't load properties
Date Tue, 10 Nov 2015 15:25:10 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998739#comment-14998739
] 

Hadoop QA commented on HBASE-14750:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12771538/HBASE-14750-20151110-1323.patch
  against master branch at commit 112900d0425a8157b89041f0e353ebf5cc259c69.
  ATTACHMENT ID: 12771538

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings
(more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16477//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16477//artifact/patchprocess/patchReleaseAuditWarnings.txt
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16477//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16477//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16477//console

This message is automatically generated.

> HBaseConfiguration.create() doesn't load properties
> ---------------------------------------------------
>
>                 Key: HBASE-14750
>                 URL: https://issues.apache.org/jira/browse/HBASE-14750
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Niels Basjes
>            Assignee: Niels Basjes
>         Attachments: HBASE-14750-20151110-1323.patch
>
>
> While writing an application that uses HBase I ran into the problem that although I have
setup the hbase-site.xml in the {{HBASE_CONF_DIR}}; the settings in this file are not picked
up in my application.
> In several places I find instructions to include things like the {{hbase.zookeeper.quorum}}
in a properties file and the explicitly set these value from within the application (I have
actually done this in the past quite a few times).
> Although this works I expect the system to automatically pickup the settings I have installed
already which are picked up by tools like the hbase shell and pig.
> So I ended up writing this helper method:
> {code:java}
>     public static Configuration createConfiguration() {
>         String hbaseConfDir = System.getenv("HBASE_CONF_DIR");
>         if (hbaseConfDir == null) {
>             hbaseConfDir = "/etc/hbase/conf";
>         }
>         Configuration conf = HBaseConfiguration.create();
>         conf.addResource(new Path(hbaseConfDir + "/hbase-site.xml"));
>         return conf;
>     }
> {code}
> I expect HBaseConfiguration.create() to give me a working config in an environment where
everything for all the other HBase clients has already been setup correctly.
> My proposal is to change the HBaseConfiguration.create() to effectively include what
my helper method does.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message