hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14728) TestRowCounter is broken in master
Date Mon, 02 Nov 2015 21:01:29 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986037#comment-14986037
] 

Hudson commented on HBASE-14728:
--------------------------------

FAILURE: Integrated in HBase-TRUNK #6985 (See [https://builds.apache.org/job/HBase-TRUNK/6985/])
HBASE-14728 TestRowCounter is broken in master (Abhishek Singh Chouhan) (stack: rev 47659200ac1d53590379ff431c428dffc07fd06a)
* pom.xml
* dev-support/jenkinsEnv.sh
* dev-support/publish_hbase_website.sh
* hbase-spark/pom.xml
* conf/hbase-env.cmd
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java
* conf/hbase-env.sh
Revert "HBASE-14728 TestRowCounter is broken in master (Abhishek Singh (stack: rev 950050e9d61299afa9efcbece053813fdaa4860d)
* pom.xml
* dev-support/publish_hbase_website.sh
* dev-support/jenkinsEnv.sh
* hbase-spark/pom.xml
* conf/hbase-env.sh
* conf/hbase-env.cmd
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java
HBASE-14728 TestRowCounter is broken in master (Abhishek Singh Chouhan) (stack: rev 6c5da91b18d002888dce9d9a4e78cd395face54f)
* hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java


> TestRowCounter is broken in master
> ----------------------------------
>
>                 Key: HBASE-14728
>                 URL: https://issues.apache.org/jira/browse/HBASE-14728
>             Project: HBase
>          Issue Type: Test
>    Affects Versions: 2.0.0
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14728.patch, HBASE-14728.patch
>
>
> The runRowCount method simply runs the RowCounter and checks if the exit code is zero
but does not actually check the row count returned
> {noformat}
> private void runRowCount(String[] args, int expectedCount) throws Exception {
>     final RowCounter counter = new RowCounter();
>     assertEquals("job failed either due to failure or miscount (see log output).", 0,
>         ToolRunner.run(TEST_UTIL.getConfiguration(), counter, args));
>   }
> {noformat}
> This will always give a false positive provided the job ran without errors (irrespective
of the count it gives).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message