hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14727) Add block cache stats for regions
Date Tue, 17 Nov 2015 21:34:10 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009565#comment-15009565
] 

Andrew Purtell commented on HBASE-14727:
----------------------------------------

{code}
+  /**
+   * @return the cache hit ratio of latest N periods for the region.
+   */
+  public String getCacheHitRatioLatestNPeriods() {
+    return regionLoadPB.getCacheHitRatioLatestNPeriods();
+  }
{code}

and 

{code}
+  /** the cache hit ratio of latest N peroids for the region */
+  optional string cache_hit_ratio_latest_N_periods = 25;
{code}

Do we need this? Operators can collect the caching metrics we periodically export and trend
this information however they like using their preferred metrics store and tooling. Would
remove a fair amount of new code from this patch. 

> Add block cache stats for regions
> ---------------------------------
>
>                 Key: HBASE-14727
>                 URL: https://issues.apache.org/jira/browse/HBASE-14727
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Eungsop Yoo
>            Priority: Minor
>         Attachments: HBASE-14727-v1.patch, HBASE-14727-v2.patch, HBASE-14727.patch, rs-web-ui.png
>
>
> The stats of block cache are calculated at region server level only. So at region level,
we could not know about the numbers of blocks cached, the sizes of cached blocks, the numbers
of cache hit, etc. I suggest to add the stats of block cache at region level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message