hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock
Date Mon, 02 Nov 2015 12:37:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985149#comment-14985149
] 

ramkrishna.s.vasudevan commented on HBASE-14575:
------------------------------------------------

bq.readLock.lock(); // hold region open while we create scanners over storefiles.
I think we can be relaxed here? Because after doing the selection while doing compaction if
the region closes - we will end up in an exception for that compaction right?
But the lock held here
{code}
// Do the steps necessary to complete the compaction. Hold region open for these operations.
1256	      region.lock.readLock().lock();
{code}
may be needed because before the region could close we could finalize the compaction if it
has really done the major work of reading and writing into a new file. So that even if the
reigon is moving the compaction need not be done once again in the new RS. 

> Reduce scope of compactions holding region lock
> -----------------------------------------------
>
>                 Key: HBASE-14575
>                 URL: https://issues.apache.org/jira/browse/HBASE-14575
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction, regionserver
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 14575-v1.patch, 14575-v2.patch, 14575-v3.patch, 14575-v4.patch,
14575.v00.patch
>
>
> Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope of critical
section under which compactions hold the region read lock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message