hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jerry He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock
Date Mon, 02 Nov 2015 05:59:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984784#comment-14984784

Jerry He commented on HBASE-14575:

As [~ndimiduk] mentioned, we've been doing a lot of checks for close (store.areWritesEnabled())
in performCompaction()
Maybe we could a couple of more outside of performCompaction() and in between we try to hold
the region read lock?

bq. +    readLock.lock();   // hold region open while we create scanners over storefiles.
It is probably good to do this.  But there seems to be no critical section to protect here
and can be relaxed as well?

> Reduce scope of compactions holding region lock
> -----------------------------------------------
>                 Key: HBASE-14575
>                 URL: https://issues.apache.org/jira/browse/HBASE-14575
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction, regionserver
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 14575-v1.patch, 14575-v2.patch, 14575-v3.patch, 14575-v4.patch,
> Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope of critical
section under which compactions hold the region read lock.

This message was sent by Atlassian JIRA

View raw message