hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock
Date Wed, 18 Nov 2015 16:49:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011377#comment-15011377
] 

Ted Yu commented on HBASE-14575:
--------------------------------

The description from 04/Nov/15 09:00 is mostly accurate:
w.r.t. #4 swap in compacted files, region lock is not needed accordingly to subsequent discussion.

bq. why is not included in the patch

The explanation is pretty long. How about putting the explanation in description of this JIRA
and refer to JIRA number in the patch ?

I reran ITBLL with the following parameters and it passed as well (with region lock relaxation):

bin/hbase --config /etc/hbase/conf org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList
Loop 4 12 2000000 /tmp/hbase-biglinkedlist-verify 8 500000 --monkey slowDeterministic


> Reduce scope of compactions holding region lock
> -----------------------------------------------
>
>                 Key: HBASE-14575
>                 URL: https://issues.apache.org/jira/browse/HBASE-14575
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction, regionserver
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 14575-test-case.patch, 14575-v1.patch, 14575-v2.patch, 14575-v3.patch,
14575-v4.patch, 14575-v5.patch, 14575-v6.txt, 14575-v6.txt, 14575-v6.txt, 14575.v00.patch
>
>
> Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope of critical
section under which compactions hold the region read lock.
> Here is summary from parent issue:
> Another idea is we can reduce the scope of when the read lock is held during compaction.
In theory the compactor only needs a region read lock while deciding what files to compact
and at the time of committing the compaction. We're protected from the case of region close
events because compactions are checking (every 10k bytes written) if the store has been closed
in order to abort in such a case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message