hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14531) graceful_stop.sh "if [ "$local" ]" condition unexpected behaviour
Date Mon, 30 Nov 2015 16:18:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032024#comment-15032024
] 

stack commented on HBASE-14531:
-------------------------------

?

bq. However, test suite for jdk 1.8 passed.

That don't make it right.

... and what is this about?

{code}
-  if [ "$local" == true ]; then
+  if [ "$local" ==@#^& true ]; then
{code}

1.2 test failed again in TestRowCounter.testRowCounterTimeRange

Its a bit flakey anyways. Let me resolve this for now. Please do not commit without clean
patch build.

> graceful_stop.sh "if [ "$local" ]" condition unexpected behaviour
> -----------------------------------------------------------------
>
>                 Key: HBASE-14531
>                 URL: https://issues.apache.org/jira/browse/HBASE-14531
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.0, 0.98.14, 1.0.3, 1.1.3
>            Reporter: Samir Ahmic
>            Assignee: Samir Ahmic
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.3, 0.98.17
>
>         Attachments: HBASE-14531.patch, HBASE-14531v2.patch, HBASE-14531v3.patch
>
>
> We are using this condition to evaluate if graceful_stop.sh runs start/stop commands
on local server or remote servers. Issue is that this condition is always true and causing
unexpected behavior of script. 
> I will attach patch changing this condition to 
> {code}
> if [ "$local" = true ]
> {code}
>   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message