hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heng Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14279) Race condition in ConcurrentIndex
Date Fri, 06 Nov 2015 04:11:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14993063#comment-14993063
] 

Heng Chen commented on HBASE-14279:
-----------------------------------

{quote}
Defensively copy under the lock of the segment 
{quote}
Make sense,  fix it.

{quote}
valueSetFactory is almost meaningless
{quote}
I don't think so,  because BucketCache will define sortedSet by itself, so we should pass
the comparator into it.

I add some tests to verify this class. 

Thanks [~ikeda] a lot.   update patch

 

> Race condition in ConcurrentIndex
> ---------------------------------
>
>                 Key: HBASE-14279
>                 URL: https://issues.apache.org/jira/browse/HBASE-14279
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Hiroshi Ikeda
>            Assignee: Heng Chen
>            Priority: Minor
>         Attachments: HBASE-14279.patch, HBASE-14279_v2.patch, HBASE-14279_v3.patch, HBASE-14279_v4.patch,
LockStripedBag.java
>
>
> {{ConcurrentIndex.put}} and {{remove}} are in race condition. It is possible to remove
a non-empty set, and to add a value to a removed set. Also {{ConcurrentIndex.values}} is vague
in sense that the returned set sometimes trace the current state and sometimes doesn't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message