hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13984) Add option to allow caller to know the heartbeat and scanner position when scanner timeout
Date Fri, 20 Nov 2015 16:52:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018315#comment-15018315
] 

Hadoop QA commented on HBASE-13984:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12773509/HBASE-13984-V5.diff
  against master branch at commit 86be690b0723e814a655ad0ae8a6577d7111c1f2.
  ATTACHMENT ID: 12773509

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 20 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 18699 checkstyle
errors (more than the master's current 18690 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +      "\002 \001(\004\022\024\n\014more_results\030\003 \001(\010\022\013\n\003ttl\030\004
\001(\r" +
+              new java.lang.String[] { "Region", "Scan", "ScannerId", "NumberOfRows", "CloseScanner",
"NextCallSeq", "ClientHandlesPartials", "ClientHandlesHeartbeats", "TrackScanMetrics", "Timeout",
"HeartbeatReturnNext", });
+              new java.lang.String[] { "CellsPerResult", "ScannerId", "MoreResults", "Ttl",
"Results", "Stale", "PartialFlagPerResult", "MoreResultsInRegion", "HeartbeatMessage", "ScanMetrics",
"HeartbeatNext", });
+      "name\030\005 \001(\t\"\032\n\004Type\022\t\n\005HFILE\020\001\022\007\n\003WAL\020\002\"\323"
+

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16615//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16615//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16615//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16615//console

This message is automatically generated.

> Add option to allow caller to know the heartbeat and scanner position when scanner timeout
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13984
>                 URL: https://issues.apache.org/jira/browse/HBASE-13984
>             Project: HBase
>          Issue Type: Improvement
>          Components: Scanners
>            Reporter: He Liangliang
>            Assignee: He Liangliang
>         Attachments: HBASE-13984-V1.diff, HBASE-13984-V2.diff, HBASE-13984-V3.diff, HBASE-13984-V3.patch,
HBASE-13984-V4.diff, HBASE-13984-V5.diff
>
>
> HBASE-13090 introduced scanner heartbeat. However, there are still some limitations (see
HBASE-13215). In some application, for example, an operation access hbase to scan table data,
and there is strict limit that this call must return in a fixed interval. At the same time,
this call is stateless, so the call must return the next position to continue the scan. This
is typical use case for online applications.
> Based on this requirement, some improvements are proposed:
> 1. Allow client set a flag whether pass the heartbeat (a result contains the scanner
position) to the caller (via ResultScanner next)
> 2. Allow the client pass a timeout to the server, which can override the server side
default value
> 3. When requested by the client, the server peek the next cell and return to the client
in the heartbeat message



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message