hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhishek Singh Chouhan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-13347) Deprecate FirstKeyValueMatchingQualifiersFilter
Date Fri, 20 Nov 2015 11:01:11 GMT

     [ https://issues.apache.org/jira/browse/HBASE-13347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Abhishek Singh Chouhan updated HBASE-13347:
-------------------------------------------
             Assignee: Abhishek Singh Chouhan
    Affects Version/s:     (was: 1.0.0)
                       2.0.0
             Priority: Minor  (was: Major)
        Fix Version/s:     (was: 1.0.4)
                           (was: 1.1.4)
                           (was: 1.2.1)
          Description: 
The {{RowCounter}} in the {{mapreduce}} package uses {{FirstKeyValueMatchingQualifiersFilter}}
which was introduced in HBASE-6468. However we do not need that since we match columns in
the scan before we filter.

Deprecate the filter in 2.0 and remove in 3.0.
Do cleanup of RowCounter that tries to use this filter but actually doesn't.

  was:
The {{RowCounter}} in the {{mapreduce}} package is supposed to check if the row count scan
has a column selection added to it, and if so, use a different filter that finds the row and
counts it. But the {{qualifier.add()}} call is missing in the {{for}} loop. See https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java#L165

Needs fixing or row count might be wrong when using {{--range}}.

          Component/s:     (was: mapreduce)
           Issue Type: Improvement  (was: Bug)
              Summary: Deprecate FirstKeyValueMatchingQualifiersFilter  (was: RowCounter using
special filter is broken)

> Deprecate FirstKeyValueMatchingQualifiersFilter
> -----------------------------------------------
>
>                 Key: HBASE-13347
>                 URL: https://issues.apache.org/jira/browse/HBASE-13347
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Lars George
>            Assignee: Abhishek Singh Chouhan
>            Priority: Minor
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-13347-master.patch
>
>
> The {{RowCounter}} in the {{mapreduce}} package uses {{FirstKeyValueMatchingQualifiersFilter}}
which was introduced in HBASE-6468. However we do not need that since we match columns in
the scan before we filter.
> Deprecate the filter in 2.0 and remove in 3.0.
> Do cleanup of RowCounter that tries to use this filter but actually doesn't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message