hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhishek Singh Chouhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13347) RowCounter using special filter is broken
Date Fri, 20 Nov 2015 06:44:10 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015313#comment-15015313
] 

Abhishek Singh Chouhan commented on HBASE-13347:
------------------------------------------------

Yep. The FirstKeyValueMatchingQualifiersFilter looks obsolete since scan already takes care
of giving only the rows that match the given qualifier. 
On a side note, FirstKeyValueMatchingQualifiersFilter seems only to be used by rowCounter
internally in the code, is there any particular use case that it solves? If not, maybe we
can deprecate/remove that as well?

> RowCounter using special filter is broken
> -----------------------------------------
>
>                 Key: HBASE-13347
>                 URL: https://issues.apache.org/jira/browse/HBASE-13347
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 1.0.0
>            Reporter: Lars George
>             Fix For: 2.0.0, 1.3.0, 1.2.1, 1.1.4, 1.0.4
>
>         Attachments: HBASE-13347-master.patch
>
>
> The {{RowCounter}} in the {{mapreduce}} package is supposed to check if the row count
scan has a column selection added to it, and if so, use a different filter that finds the
row and counts it. But the {{qualifier.add()}} call is missing in the {{for}} loop. See https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java#L165
> Needs fixing or row count might be wrong when using {{--range}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message