hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heng Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11393) Replication TableCfs should be a PB object rather than a string
Date Wed, 04 Nov 2015 02:32:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988770#comment-14988770
] 

Heng Chen commented on HBASE-11393:
-----------------------------------

Thanks [~enis]
{quote}
First, the String based configuration for table cfs should completely be deprecated. 
{quote}
I will do it.

{quote}
Second, I think we should unify the ReplicationPeerConfiguration and table-cf configuration
so that the table CF's to filter goes inside the ReplicationPeerConfiguration.
{quote}

Sounds good.  But it has no relates with this issue.  Shall we open another one to do it?

Additional concerns:
Currently,  {{ReplicationPeersZKImpl}} and {{ReplicationPeerZKImpl}} has some overlaps.  
They all has method getTableCFs, {{ReplicationPeersZKImpl}} read directly relates ZNode, 
but {{ReplicationPeerZKImpl}} read it from memory which updates by ZK notified.
Shall we unify them?






> Replication TableCfs should be a PB object rather than a string
> ---------------------------------------------------------------
>
>                 Key: HBASE-11393
>                 URL: https://issues.apache.org/jira/browse/HBASE-11393
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11393.patch, HBASE-11393_v1.patch, HBASE-11393_v2.patch, HBASE-11393_v3.patch,
HBASE-11393_v4.patch, HBASE-11393_v5.patch, HBASE-11393_v6.patch, HBASE-11393_v7.patch
>
>
> We concatenate the list of tables and column families in format  "table1:cf1,cf2;table2:cfA,cfB"
in zookeeper for table-cf to replication peer mapping. 
> This results in ugly parsing code. We should do this a PB object. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message