Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 27 Oct 2015 12:54:27 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12907674.1445711954000.71790.1445950467710@Atlassian.JIRA>
In-Reply-To: <JIRA.12907674.1445711954000@Atlassian.JIRA>
References: <JIRA.12907674.1445711954000@Atlassian.JIRA>
 <JIRA.12907674.1445711954258@arcas>
Subject: [jira] [Commented] (HBASE-14693) Add client-side metrics for
 received pushback signals
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976321#comment-14976321 ] 

Hadoop QA commented on HBASE-14693:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12768925/HBASE-14693_v3.patch
  against master branch at commit 4269c7fe69baabbd813dcdf6ed0b3a57ea4b41de.
  ATTACHMENT ID: 12768925

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +    assertEquals(rsStats.heapOccupancyHist.mean(), (double)regionStats.getHeapOccupancyPercent(), 0.1 );
+    assertEquals(rsStats.memstoreLoadHist.mean(), (double)regionStats.getMemstoreLoadPercent(), 0.1);

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16245//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16245//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16245//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16245//console

This message is automatically generated.

> Add client-side metrics for received pushback signals
> -----------------------------------------------------
>
>                 Key: HBASE-14693
>                 URL: https://issues.apache.org/jira/browse/HBASE-14693
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Andrew Purtell
>            Assignee: Heng Chen
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.16
>
>         Attachments: HBASE-14693.patch, HBASE-14693_v1.patch, HBASE-14693_v2.patch, HBASE-14693_v3.patch
>
>
> HBASE-12911 added client side metrics. HBASE-5162 added a mechanism for sending advisory backpressure signals to clients when the server is heavily loaded, and HBASE-12702 and subtasks backported this to all active branches. Add client-side metrics for received pushback signal. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)