Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4D86E18913 for ; Wed, 28 Oct 2015 01:13:33 +0000 (UTC) Received: (qmail 13498 invoked by uid 500); 28 Oct 2015 01:13:28 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 13404 invoked by uid 500); 28 Oct 2015 01:13:28 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 13265 invoked by uid 99); 28 Oct 2015 01:13:28 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Oct 2015 01:13:28 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D9F062C1F5C for ; Wed, 28 Oct 2015 01:13:27 +0000 (UTC) Date: Wed, 28 Oct 2015 01:13:27 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14680) Two configs for snapshot timeout and better defaults MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977517#comment-14977517 ] Hudson commented on HBASE-14680: -------------------------------- FAILURE: Integrated in HBase-1.0 #1103 (See [https://builds.apache.org/job/HBase-1.0/1103/]) HBASE-14680 Two configs for snapshot timeout and better defaults (Heng (enis: rev 25b4427ee8f36f78174141816804a8e7b2d76d9f) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/snapshot/RegionServerSnapshotManager.java * hbase-common/src/main/resources/hbase-default.xml * hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java > Two configs for snapshot timeout and better defaults > ---------------------------------------------------- > > Key: HBASE-14680 > URL: https://issues.apache.org/jira/browse/HBASE-14680 > Project: HBase > Issue Type: Bug > Reporter: Enis Soztutar > Assignee: Heng Chen > Fix For: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.3, 0.98.16 > > Attachments: HBASE-14680.patch, HBASE-14680_v1.patch, HBASE-14680_v2.patch, hbase-14680_v3.patch > > > One of the clusters timed out taking a snapshot for a disabled table. The table is big enough, and the master operation takes more than 1 min to complete. However while trying to increase the timeout, we noticed that there are two parameters with very similar names configuring different things: > {{hbase.snapshot.master.timeout.millis}} is defined in SnapshotDescriptionUtils and is send to client side and used in disabled table snapshot. > {{hbase.snapshot.master.timeoutMillis}} is defined in SnapshotManager and used as the timeout for the procedure execution. > So, there are a couple of improvements that we can do: > - 1 min is too low for big tables. We need to set this to 5 min or 10 min by default. Even a 6T table which is medium sized fails. > - Unify the two timeouts into one. Decide on either of them, and deprecate the other. Use the biggest one for BC. > - Add the timeout to hbase-default.xml. > - Why do we even have a timeout for disabled table snapshots? The master is doing the work so we should not timeout in any case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)