Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 23 Oct 2015 21:32:27 +0000 (UTC)
From: "Enis Soztutar (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12907208.1445547686000.45714.1445635947822@Atlassian.JIRA>
In-Reply-To: <JIRA.12907208.1445547686000@Atlassian.JIRA>
References: <JIRA.12907208.1445547686000@Atlassian.JIRA>
 <JIRA.12907208.1445547686640@arcas>
Subject: [jira] [Commented] (HBASE-14680) Two configs for snapshot timeout
 and better defaults
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971891#comment-14971891 ] 

Enis Soztutar commented on HBASE-14680:
---------------------------------------

bq. When you take a snapshot a disabled table, the Master is doing the work, so I don't think there's any RPCs to region servers. (that's what Enis was getting at in the description, I imagine).
Yep. 
bq. Also, it looks like your patch just outright deletes the configuration property instead of deprecating it. If this change lands on the bug-fix branches, we should still adhere to all of the properties if the user provides them. 
Agreed. 

BTW, I prefer {{timeout.millis}} over {{timeoutMillis}}. 

[~mbertozzi] FYI. 

> Two configs for snapshot timeout and better defaults
> ----------------------------------------------------
>
>                 Key: HBASE-14680
>                 URL: https://issues.apache.org/jira/browse/HBASE-14680
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>             Fix For: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.3, 0.98.16
>
>         Attachments: HBASE-14680.patch
>
>
> One of the clusters timed out taking a snapshot for a disabled table. The table is big enough, and the master operation takes more than 1 min to complete. However while trying to increase the timeout, we noticed that there are two parameters with very similar names configuring different things: 
> {{hbase.snapshot.master.timeout.millis}} is defined in SnapshotDescriptionUtils and is send to client side and used in disabled table snapshot. 
> {{hbase.snapshot.master.timeoutMillis}} is defined in SnapshotManager and used as the timeout for the procedure execution. 
> So, there are a couple of improvements that we can do: 
>  - 1 min is too low for big tables. We need to set this to 5 min or 10 min by default. Even a 6T table which is medium sized fails. 
>  - Unify the two timeouts into one. Decide on either of them, and deprecate the other. Use the biggest one for BC. 
>  - Add the timeout to hbase-default.xml. 
>  - Why do we even have a timeout for disabled table snapshots? The master is doing the work so we should not timeout in any case. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)