Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E58CD18265 for ; Tue, 13 Oct 2015 04:32:06 +0000 (UTC) Received: (qmail 10043 invoked by uid 500); 13 Oct 2015 04:32:06 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 9988 invoked by uid 500); 13 Oct 2015 04:32:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 9973 invoked by uid 99); 13 Oct 2015 04:32:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Oct 2015 04:32:06 +0000 Date: Tue, 13 Oct 2015 04:32:06 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14588) Stop accessing test resources from within src folder MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954362#comment-14954362 ] Hadoop QA commented on HBASE-14588: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12766162/hbase-14588.002.patch against master branch at commit 2ff6d0fe4789857ab51685949711d755dedd459a. ATTACHMENT ID: 12766162 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 15 new or modified tests. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15981//console This message is automatically generated. > Stop accessing test resources from within src folder > ---------------------------------------------------- > > Key: HBASE-14588 > URL: https://issues.apache.org/jira/browse/HBASE-14588 > Project: HBase > Issue Type: Improvement > Affects Versions: 1.1.0 > Reporter: Andrew Wang > Assignee: Andrew Wang > Attachments: hbase-14588.001.patch, hbase-14588.001.patch, hbase-14588.002.patch > > > A few tests in hbase-server reach into the src/test/data folder to get test resources, which is naughty since tests are supposed to only operate within the target/ folder. It's better to put these into src/test/resources and let them be automatically copied into target/ via the resources plugin, like other test resources. -- This message was sent by Atlassian JIRA (v6.3.4#6332)