Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 1 Oct 2015 11:12:27 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12901565.1443614567000.1185.1443697947137@Atlassian.JIRA>
In-Reply-To: <JIRA.12901565.1443614567000@Atlassian.JIRA>
References: <JIRA.12901565.1443614567000@Atlassian.JIRA>
 <JIRA.12901565.1443614567588@arcas>
Subject: [jira] [Commented] (HBASE-14523) rolling-restart.sh --graceful will
 start regionserver process on master node
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-14523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939689#comment-14939689 ] 

Hadoop QA commented on HBASE-14523:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12764561/HBASE-14523.patch
  against master branch at commit 76463a36f5648f42cdcf64019a825c1e3f0c4fe1.
  ATTACHMENT ID: 12764561

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev-support patch that doesn't require tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15838//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15838//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15838//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15838//console

This message is automatically generated.

> rolling-restart.sh --graceful will start regionserver process on master node
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-14523
>                 URL: https://issues.apache.org/jira/browse/HBASE-14523
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.0
>            Reporter: Samir Ahmic
>            Assignee: Samir Ahmic
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14523.patch
>
>
> In master branch master acts also as regionserver hosting 'hbase:meta' table and it has ephemeral znode created in '/hbase/rs'. Because of this rolling-restart.sh --graceful will pick up master server from zk at this line:
> {code}
> online_regionservers=`$bin/hbase zkcli ls $zkrs 2>&1 | tail -1 | sed "s/\[//" | sed "s/\]//"`
> {code}
> and will restart it a long with rest of regionservers. 
> I'm planing to add some code to rolling-restart.sh script to filter master server from above  list. 


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)