Return-Path: 
 <issues-return-215347-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 99DEC184AC
	for <apmail-hbase-issues-archive@www.apache.org>;
 Mon, 12 Oct 2015 22:17:05 +0000 (UTC)
Received: (qmail 60543 invoked by uid 500); 12 Oct 2015 22:17:05 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 60498 invoked by uid 500); 12 Oct 2015 22:17:05 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 60483 invoked by uid 99); 12 Oct 2015 22:17:05 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Oct 2015 22:17:05 +0000
Date: Mon, 12 Oct 2015 22:17:05 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12863285.1441947595000.17753.1444688225357@Atlassian.JIRA>
In-Reply-To: <JIRA.12863285.1441947595000@Atlassian.JIRA>
References: <JIRA.12863285.1441947595000@Atlassian.JIRA>
 <JIRA.12863285.1441947595992@arcas>
Subject: [jira] [Commented] (HBASE-14406) The dataframe datasource filter is
 wrong, and will result in data loss or unexpected behavior
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-14406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953857#comment-14953857 ] 

Hadoop QA commented on HBASE-14406:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12766149/HBASE-14406.4.patch
  against master branch at commit 4d1d88aa15c73bfe14911a08b0d9c1241f8a980f.
  ATTACHMENT ID: 12766149

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 5 new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping cell_to_column_mapping = 3;</code>
+     * <code>repeated .hbase.pb.SQLPredicatePushDownCellToColumnMapping cell_to_column_mapping = 3;</code>

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15970//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15970//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15970//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15970//console

This message is automatically generated.

> The dataframe datasource filter is wrong, and will result in data loss or unexpected behavior
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14406
>                 URL: https://issues.apache.org/jira/browse/HBASE-14406
>             Project: HBase
>          Issue Type: Bug
>          Components: spark
>    Affects Versions: 2.0.0
>            Reporter: Zhan Zhang
>            Assignee: Ted Malaska
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14406.1.patch, HBASE-14406.2.patch, HBASE-14406.3.patch, HBASE-14406.4.patch, HBASE-14406.5.patch, HBASE-14406.6.patch
>
>
> Following condition will result in the same filter. It will have data loss with the current filter construction.
> col1 > 4 && col2 < 3
> col1 > 4 || col2 < 3



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)