Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B1DC18C5F for ; Tue, 13 Oct 2015 09:01:06 +0000 (UTC) Received: (qmail 66583 invoked by uid 500); 13 Oct 2015 09:01:06 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 66530 invoked by uid 500); 13 Oct 2015 09:01:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 66514 invoked by uid 99); 13 Oct 2015 09:01:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Oct 2015 09:01:06 +0000 Date: Tue, 13 Oct 2015 09:01:06 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14268) Improve KeyLocker MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954658#comment-14954658 ] Hudson commented on HBASE-14268: -------------------------------- FAILURE: Integrated in HBase-1.2-IT #204 (See [https://builds.apache.org/job/HBase-1.2-IT/204/]) HBASE-14268 Improve KeyLocker (Hiroshi Ikeda) (stack: rev 0fc4614e5b830899e521b14d34db2e54126ddfd3) * hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestKeyLocker.java * hbase-common/src/main/java/org/apache/hadoop/hbase/util/KeyLocker.java > Improve KeyLocker > ----------------- > > Key: HBASE-14268 > URL: https://issues.apache.org/jira/browse/HBASE-14268 > Project: HBase > Issue Type: Improvement > Components: util > Reporter: Hiroshi Ikeda > Assignee: Hiroshi Ikeda > Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: 14268-V5.patch, HBASE-14268-V2.patch, HBASE-14268-V3.patch, HBASE-14268-V4.patch, HBASE-14268-V5.patch, HBASE-14268-V5.patch, HBASE-14268-V6.patch, HBASE-14268-V7.patch, HBASE-14268-V7.patch, HBASE-14268-V7.patch, HBASE-14268-V7.patch, HBASE-14268-V7.patch, HBASE-14268-V7.patch, HBASE-14268-V7.patch, HBASE-14268.patch, KeyLockerIncrKeysPerformance.java, KeyLockerPerformance.java, ReferenceTestApp.java > > > 1. In the implementation of {{KeyLocker}} it uses atomic variables inside a synchronized block, which doesn't make sense. Moreover, logic inside the synchronized block is not trivial so that it makes less performance in heavy multi-threaded environment. > 2. {{KeyLocker}} gives an instance of {{RentrantLock}} which is already locked, but it doesn't follow the contract of {{ReentrantLock}} because you are not allowed to freely invoke lock/unlock methods under that contract. That introduces a potential risk; Whenever you see a variable of the type {{RentrantLock}}, you should pay attention to what the included instance is coming from. -- This message was sent by Atlassian JIRA (v6.3.4#6332)