Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7939618BB1 for ; Wed, 14 Oct 2015 02:06:05 +0000 (UTC) Received: (qmail 40373 invoked by uid 500); 14 Oct 2015 02:06:05 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 40320 invoked by uid 500); 14 Oct 2015 02:06:05 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 40304 invoked by uid 99); 14 Oct 2015 02:06:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Oct 2015 02:06:05 +0000 Date: Wed, 14 Oct 2015 02:06:05 +0000 (UTC) From: "Gabor Liptak (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14256) Flush task message may be confusing when region is recovered MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956137#comment-14956137 ] Gabor Liptak commented on HBASE-14256: -------------------------------------- The compile failure seems unrelated. > Flush task message may be confusing when region is recovered > ------------------------------------------------------------ > > Key: HBASE-14256 > URL: https://issues.apache.org/jira/browse/HBASE-14256 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 2.0.0, 1.2.0 > Reporter: Lars George > Assignee: Gabor Liptak > Labels: beginner > Attachments: HBASE-14256.1.patch > > > In {{HRegion.setRecovering()}} we have this code: > {code} > // force a flush only if region replication is set up for this region. Otherwise no need. > boolean forceFlush = getTableDesc().getRegionReplication() > 1; > // force a flush first > MonitoredTask status = TaskMonitor.get().createStatus( > "Flushing region " + this + " because recovery is finished"); > try { > if (forceFlush) { > internalFlushcache(status); > } > {code} > So we only optionally force flush after a recovery of a region, but the message always is set to "Flushing...", which might be confusing. We should change the message based on {{forceFlush}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)