hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14728) TestRowCounter is broken in master
Date Fri, 30 Oct 2015 23:21:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983585#comment-14983585
] 

Hadoop QA commented on HBASE-14728:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12769837/HBASE-14728.patch
  against master branch at commit b0ad82191cc216c65751b68cbc11280fd5d5cd47.
  ATTACHMENT ID: 12769837

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16319//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16319//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16319//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16319//console

This message is automatically generated.

> TestRowCounter is broken in master
> ----------------------------------
>
>                 Key: HBASE-14728
>                 URL: https://issues.apache.org/jira/browse/HBASE-14728
>             Project: HBase
>          Issue Type: Test
>    Affects Versions: 2.0.0
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14728.patch, HBASE-14728.patch
>
>
> The runRowCount method simply runs the RowCounter and checks if the exit code is zero
but does not actually check the row count returned
> {noformat}
> private void runRowCount(String[] args, int expectedCount) throws Exception {
>     final RowCounter counter = new RowCounter();
>     assertEquals("job failed either due to failure or miscount (see log output).", 0,
>         ToolRunner.run(TEST_UTIL.getConfiguration(), counter, args));
>   }
> {noformat}
> This will always give a false positive provided the job ran without errors (irrespective
of the count it gives).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message