hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14727) Add block cache stats for regions
Date Sat, 31 Oct 2015 05:56:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983858#comment-14983858
] 

Hadoop QA commented on HBASE-14727:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12769909/HBASE-14727-v1.patch
  against master branch at commit 683f84e6a217dfd872e5f1be82c7aa4cdf232ec1.
  ATTACHMENT ID: 12769909

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 22 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1748 checkstyle
errors (more than the master's current 1730 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +        result = result && (Float.floatToIntBits(getCacheHitRatio())    == Float.floatToIntBits(other.getCacheHitRatio()));
+      result = result && (hasCacheHitRatioLatestNPeriods() == other.hasCacheHitRatioLatestNPeriods());
+              new java.lang.String[] { "RegionSpecifier", "Stores", "Storefiles", "StoreUncompressedSizeMB",
"StorefileSizeMB", "MemstoreSizeMB", "StorefileIndexSizeMB", "ReadRequestsCount", "WriteRequestsCount",
"TotalCompactingKVs", "CurrentCompactedKVs", "RootIndexSizeKB", "TotalStaticIndexSizeKB",
"TotalStaticBloomSizeKB", "CompleteSequenceId", "DataLocality", "LastMajorCompactionTs", "StoreCompleteSequenceId",
"CacheHitCount", "CacheMissCount", "CacheEvictedBlockCount", "CacheSize", "CacheBlockCount",
"CacheHitRatio", "CacheHitRatioLatestNPeriods", });
+      BlockCacheKey cacheKey = new BlockCacheKey(BlockCacheKey.parseRegion(path), name, metaBlockOffset,
+    BlockCacheKey cacheKey = new BlockCacheKey(BlockCacheKey.parseRegion(path), name, dataBlockOffset,
+    stats.evicted(block.getCacheKey().getRegion(), block.getCachedTime(), block.getCacheKey().isPrimary());

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16328//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16328//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16328//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16328//console

This message is automatically generated.

> Add block cache stats for regions
> ---------------------------------
>
>                 Key: HBASE-14727
>                 URL: https://issues.apache.org/jira/browse/HBASE-14727
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Eungsop Yoo
>            Priority: Minor
>         Attachments: HBASE-14727-v1.patch, HBASE-14727.patch, rs-web-ui.png
>
>
> The stats of block cache are calculated at region server level only. So at region level,
we could not know about the numbers of blocks cached, the sizes of cached blocks, the numbers
of cache hit, etc. I suggest to add the stats of block cache at region level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message