hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14721) Memstore add cells - Avoid many garbage
Date Fri, 30 Oct 2015 12:48:28 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982509#comment-14982509
] 

Hadoop QA commented on HBASE-14721:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12769717/HBASE-14721_branch-1.patch
  against branch-1 branch at commit 84f4cceb485379d080ec9fb000c9ce5a77638d89.
  ATTACHMENT ID: 12769717

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16302//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16302//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16302//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16302//console

This message is automatically generated.

> Memstore add cells - Avoid many garbage
> ---------------------------------------
>
>                 Key: HBASE-14721
>                 URL: https://issues.apache.org/jira/browse/HBASE-14721
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-14721.patch, HBASE-14721_branch-1.patch
>
>
> In HRegion# applyFamilyMapToMemstore()
> {code}
> for (int i=0; i < listSize; i++) {
>         Cell cell = cells.get(i);
>         if (cell.getSequenceId() == 0) {
>           CellUtil.setSequenceId(cell, mvccNum);
>         }
>         Pair<Long, Cell> ret = store.add(cell);
>         size += ret.getFirst();
>         if(isInReplay) {
>           // set memstore newly added cells with replay mvcc number
>           CellUtil.setSequenceId(ret.getSecond(), mvccNum);
>         }
>       }
> {code}
> Previously we used to pass the added Cell reference to some HLog impl classes and later
on the seqId used to get assigned.  Now it looks totally changed.  For normal put cells, the
assign happen before adding to store.
> After addition we can see in replay mode again the mvccNum assign on returned cell..
This is not really needed as the seq of seqId assign and add to memstore is changed now.
> For the previous way we had to return added Cell also and that is why we were creating
Pair object.Now we can avoid this so we can avoid creation of one Pair object and a wrapper
Long object for every Cell add..



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message