hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhishek Singh Chouhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14718) Increase sleep time in TestRegionMover#testLoadWithoutAck
Date Thu, 29 Oct 2015 17:23:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980853#comment-14980853
] 

Abhishek Singh Chouhan commented on HBASE-14718:
------------------------------------------------

Sure thing. Also we can make this test a bit less strict ie. test if we've loaded "some regions"
instead of "all regions" (since this tests loading without acknowledging which is best effort
anyways). [~asamir] let me know if you want me to take this up, since i was working on this
recently.

> Increase sleep time in TestRegionMover#testLoadWithoutAck
> ---------------------------------------------------------
>
>                 Key: HBASE-14718
>                 URL: https://issues.apache.org/jira/browse/HBASE-14718
>             Project: HBase
>          Issue Type: Test
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Samir Ahmic
>            Assignee: Samir Ahmic
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14718.patch
>
>
> I have notice this failed while working on [HBASE-14664| https://issues.apache.org/jira/browse/HBASE-14664].
Looks like test outcome depends on how fast is machine running this test. On my laptom threshold
is 50ms when test start to fail. I assume on Apache Jenkins 100ms is very close to treshold
based on exception:
> {code}
> java.lang.AssertionError: expected:<3> but was:<2>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:834)
> 	at org.junit.Assert.assertEquals(Assert.java:645)
> 	at org.junit.Assert.assertEquals(Assert.java:631)
> 	at org.apache.hadoop.hbase.util.TestRegionMover.testLoadWithoutAck(TestRegionMover.java:110)
> {code} 
> So my suggestion is to increase this to 150ms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message