hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14680) Two configs for snapshot timeout and better defaults
Date Wed, 28 Oct 2015 07:54:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977923#comment-14977923

Hudson commented on HBASE-14680:

SUCCESS: Integrated in HBase-1.3 #316 (See [https://builds.apache.org/job/HBase-1.3/316/])
HBASE-14680 Two configs for snapshot timeout and better defaults (Heng (enis: rev 87c97c231a9fdd9e3d86eb86c234ab46f58d02b6)
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/DisabledTableSnapshotHandler.java
* hbase-common/src/main/resources/hbase-default.xml
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/snapshot/RegionServerSnapshotManager.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java

> Two configs for snapshot timeout and better defaults
> ----------------------------------------------------
>                 Key: HBASE-14680
>                 URL: https://issues.apache.org/jira/browse/HBASE-14680
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Heng Chen
>             Fix For: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.3, 0.98.16
>         Attachments: HBASE-14680.patch, HBASE-14680_v1.patch, HBASE-14680_v2.patch, hbase-14680_v3.patch
> One of the clusters timed out taking a snapshot for a disabled table. The table is big
enough, and the master operation takes more than 1 min to complete. However while trying to
increase the timeout, we noticed that there are two parameters with very similar names configuring
different things: 
> {{hbase.snapshot.master.timeout.millis}} is defined in SnapshotDescriptionUtils and is
send to client side and used in disabled table snapshot. 
> {{hbase.snapshot.master.timeoutMillis}} is defined in SnapshotManager and used as the
timeout for the procedure execution. 
> So, there are a couple of improvements that we can do: 
>  - 1 min is too low for big tables. We need to set this to 5 min or 10 min by default.
Even a 6T table which is medium sized fails. 
>  - Unify the two timeouts into one. Decide on either of them, and deprecate the other.
Use the biggest one for BC. 
>  - Add the timeout to hbase-default.xml. 
>  - Why do we even have a timeout for disabled table snapshots? The master is doing the
work so we should not timeout in any case. 

This message was sent by Atlassian JIRA

View raw message