hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14680) Two configs for snapshot timeout and better defaults
Date Fri, 23 Oct 2015 13:01:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970926#comment-14970926
] 

Josh Elser commented on HBASE-14680:
------------------------------------

bq. But i has a question, after we remove timeout in disabled table snapshot, how to deal
with situation if snapshot action hangs by some reason something like 'Region Connection timeout'..

When you take a snapshot a disabled table, the Master is doing the work, so I don't think
there's any RPCs to region servers. (that's what Enis was getting at in the description, I
imagine).

Also, it looks like your patch just outright deletes the configuration property instead of
deprecating it. If this change lands on the bug-fix branches, we should still adhere to all
of the properties if the user provides them. This might cause some surprises for people upgrading
within a release line.

> Two configs for snapshot timeout and better defaults
> ----------------------------------------------------
>
>                 Key: HBASE-14680
>                 URL: https://issues.apache.org/jira/browse/HBASE-14680
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>             Fix For: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.3, 0.98.16
>
>         Attachments: HBASE-14680.patch
>
>
> One of the clusters timed out taking a snapshot for a disabled table. The table is big
enough, and the master operation takes more than 1 min to complete. However while trying to
increase the timeout, we noticed that there are two parameters with very similar names configuring
different things: 
> {{hbase.snapshot.master.timeout.millis}} is defined in SnapshotDescriptionUtils and is
send to client side and used in disabled table snapshot. 
> {{hbase.snapshot.master.timeoutMillis}} is defined in SnapshotManager and used as the
timeout for the procedure execution. 
> So, there are a couple of improvements that we can do: 
>  - 1 min is too low for big tables. We need to set this to 5 min or 10 min by default.
Even a 6T table which is medium sized fails. 
>  - Unify the two timeouts into one. Decide on either of them, and deprecate the other.
Use the biggest one for BC. 
>  - Add the timeout to hbase-default.xml. 
>  - Why do we even have a timeout for disabled table snapshots? The master is doing the
work so we should not timeout in any case. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message