hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14676) HBaseTestCase clean out: Purge Incommon Interface and Table and Region implementations
Date Sat, 24 Oct 2015 00:51:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972218#comment-14972218

stack commented on HBASE-14676:

bq. Does closing the regionscanner inside RegionScannerToResultScannerAdaptor make sense?

I think so given its an adaptor. ResultScanner is what the clients gets and they have no access
to RegionScanner.

bq. Any reason why checkAndPut/checkAndDelete/ICV/checkAndMutate were skipped? Implement,
add a todo, or add reason why?

See head of the class: "Some API is not implemented yet (throws {@link UnsupportedOperationException})."

On naming, we are making a 'Table', so RegionToTable* don't work because its a Table, not
a Region.

RegionAsTable seems a bit awkward.. but could do that.  I like RegionTable since we are meshing
a Region and Table Interface with Table being the class implemented: i.e. the root.

Any other good names for this class? Anyone?

> HBaseTestCase clean out: Purge Incommon Interface and Table and Region implementations
> --------------------------------------------------------------------------------------
>                 Key: HBASE-14676
>                 URL: https://issues.apache.org/jira/browse/HBASE-14676
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>         Attachments: 14676.patch, 14676v2.txt, 14676v3.txt, RegionAdmin.java
> As part of the hollowing out of the old HBaseTestCase in preparation for removal, this
patch purges the old Incommon trick that made it so you could pass an Interface to a method
to do loading or testing and the implementation could be an HTable or a Region.  Instead,
replace it with a RegionTable, a Regoin that has the Table Interface as a decoration so you
can use same loading code and same test both on top of the Region or on other side of network
via HTable.

This message was sent by Atlassian JIRA

View raw message