hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jerry He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
Date Thu, 22 Oct 2015 20:07:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969802#comment-14969802

Jerry He commented on HBASE-14655:

A general comment here.
The purpose of the original JIRA is to be able to ACL check and audit the 'request' user before
perform the user compaction request.
The AccessController only implemented preCommit(), with no checking or auditing for the other
preXXX (e.g preCompactSelection, preCompactScannerOpen) or postXXX.
I have wondered if it is necessary to enclose all these call in doAs().
Also since it would cover calls to all coprocessor implementations of these methods, including
user custom coprocessors,  should limited behavior change be more desired?
[~apurtell] may have a better idea than mine on this.

Other than this, the v9 patch looks good.

> Narrow the scope of doAs() calls to region observer notifications for compaction
> --------------------------------------------------------------------------------
>                 Key: HBASE-14655
>                 URL: https://issues.apache.org/jira/browse/HBASE-14655
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 14655-0.98-v9.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt,
14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt,
14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt,
14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt,
14655-v8.txt, 14655-v9.txt
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling doAs() for
compaction related region observer notifications should be narrowed.
> User object is passed from CompactSplitThread down to the methods where region observer
notifications are made.

This message was sent by Atlassian JIRA

View raw message