hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
Date Thu, 22 Oct 2015 19:14:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969699#comment-14969699
] 

Hadoop QA commented on HBASE-14655:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12768069/14655-branch-1.0-v9.txt
  against branch-1.0 branch at commit 619a240ebd6305eb2fdca8efe104a9ee92065ff6.
  ATTACHMENT ID: 12768069

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 18 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 3766 checkstyle
errors (more than the master's current 3765 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +    byte[] left, byte[] right, byte[] majorRangeFromRow, byte[] majorRangeToRow) throws
IOException {
+        dropDeletesMatcher(dropDeletes, start), dropDeletesMatcher(dropDeletes, end), any(User.class));

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16174//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16174//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16174//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16174//console

This message is automatically generated.

> Narrow the scope of doAs() calls to region observer notifications for compaction
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-14655
>                 URL: https://issues.apache.org/jira/browse/HBASE-14655
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 14655-0.98-v9.txt, 14655-branch-1-v5.txt, 14655-branch-1-v6.txt,
14655-branch-1-v7.txt, 14655-branch-1-v8.txt, 14655-branch-1-v9.txt, 14655-branch-1.0-v10.txt,
14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt, 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt,
14655-v1.txt, 14655-v2.txt, 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt,
14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling doAs() for
compaction related region observer notifications should be narrowed.
> User object is passed from CompactSplitThread down to the methods where region observer
notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message