hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jerry He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14655) Narrow the scope of doAs() calls to region observer notifications for compaction
Date Wed, 21 Oct 2015 23:29:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968167#comment-14968167
] 

Jerry He commented on HBASE-14655:
----------------------------------

Looks good overall.  The approach is similar to  HBASE-14605 (split) and HBASE-14631 (merge).
But compaction has its own complexity.
A couple of questions.
1. Looks like only the default compactor will behave as doAs().  Stripe compaction will not?
2. The interface change in Store, which is marked as LimitedPrivate(HBaseInterfaceAudience.COPROC).
 Should anything be deprecated or marked?  The other method changes seem to be all private.

> Narrow the scope of doAs() calls to region observer notifications for compaction
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-14655
>                 URL: https://issues.apache.org/jira/browse/HBASE-14655
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 14655-branch-1-v5.txt, 14655-v1.txt, 14655-v2.txt, 14655-v3.txt,
14655-v4.txt, 14655-v5.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling doAs() for
compaction related region observer notifications should be narrowed.
> User object is passed from CompactSplitThread down to the methods where region observer
notifications are made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message