hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14636) Clear HFileScannerImpl#prevBlocks in between Compaction flow
Date Mon, 19 Oct 2015 20:59:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964042#comment-14964042
] 

stack commented on HBASE-14636:
-------------------------------

The patch seems to be doing well in my testbed (it takes a good few hours to run).  Will keep
you posted. We got much further than w/o the patch.

On the patch:

this.curBlock.getMemoryType() == MemoryType.SHARED

Can we keep this internal to the block rather than have HFileScannerImpl have to know about
SHARED?... Maybe a method on block... 

Sort of similiar, this bit where we do a check every two seconds...... could we change it
to be size based?

  private static final long COMPACTION_PROGRESS_SHIPPED_CALL_INTERVAL = 2 * 1000;

Could it be a method in KeyValueScanner that checks if we need to ship?

Could call  kvs.shipped(); everytime through and it figures when to ship?  Or add a 'ship'
method and if it returns true, then called shipped (Is that right? The method is 'shipped'.
Have the KVs been shipped at this stage or does this method ship them? If it ships them, the
method should be 'ship' rather than 'shipped'?)



> Clear HFileScannerImpl#prevBlocks in between Compaction flow
> ------------------------------------------------------------
>
>                 Key: HBASE-14636
>                 URL: https://issues.apache.org/jira/browse/HBASE-14636
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14636.patch, HBASE-14636.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message