hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Singhi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14629) Create replication zk node in postLogRoll instead of preLogRoll
Date Fri, 16 Oct 2015 15:32:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960887#comment-14960887

Ashish Singhi commented on HBASE-14629:

The first thought that stuck to me while looking into the code was that why we add log in
ZK during preLogRoll and and in queue during postLogRoll. But ignored at that time thinking
there might be some reason which I may not be able to find out at that moment.

> Create replication zk node in postLogRoll instead of preLogRoll
> ---------------------------------------------------------------
>                 Key: HBASE-14629
>                 URL: https://issues.apache.org/jira/browse/HBASE-14629
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: He Liangliang
> Currently the hlog zk node is added before creating the log file, so it's possible to
raise FileNotFoundException if the server crash between these tow operations. Move this step
after file creating can avoid this exception (then FNFE will be certainly treated as an error).
If there is an crash after log creation before creating the zk node, the log will be replayed
and there should be no data loss either.

This message was sent by Atlassian JIRA

View raw message