hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14604) Improve MoveCostFunction in StochasticLoadBalancer
Date Mon, 19 Oct 2015 12:53:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963258#comment-14963258
] 

Hadoop QA commented on HBASE-14604:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12767319/HBASE-14604_98_with_ut.diff
  against master branch at commit 8e6316a80cf96f4d4cd6bd10f4c647ebf45c7e02.
  ATTACHMENT ID: 12767319

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16094//console

This message is automatically generated.

> Improve MoveCostFunction in StochasticLoadBalancer
> --------------------------------------------------
>
>                 Key: HBASE-14604
>                 URL: https://issues.apache.org/jira/browse/HBASE-14604
>             Project: HBase
>          Issue Type: Bug
>          Components: Balancer
>    Affects Versions: 0.98.15
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>         Attachments: HBASE-14604_98.diff, HBASE-14604_98_with_ut.diff
>
>
> The code in MoveCoseFunction:
> {code}
> return scale(0, cluster.numRegions + META_MOVE_COST_MULT, moveCost);
> {code}
> It uses cluster.numRegions + META_MOVE_COST_MULT as the max value when scale moveCost
to [0,1]. But this should use maxMoves as the max value when cluster have a lot of regions.
> Assume a cluster have 10000 regions, maxMoves is 2500, it only scale moveCost to [0,
0.25].
> Improve moveCost by use Math.min(cluster.numRegions, maxMoves) as the max cost, so it
can scale moveCost to [0,1].
> {code}
> return scale(0, Math.min(cluster.numRegions, maxMoves) + META_MOVE_COST_MULT, moveCost);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message