hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heng Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14600) Make #testWalRollOnLowReplication looser still
Date Mon, 19 Oct 2015 07:02:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962936#comment-14962936
] 

Heng Chen commented on HBASE-14600:
-----------------------------------


{code}
if (msg != null && msg.toLowerCase().contains("sync aborted") && i > 50)
{ return; }
+ throw re;
}
{code}
Just as i said in HBASE-14608,  i think we should NOT add {{throw e}}.

Otherwise it will break down this testcase when i<50,  we'd better just catch "Sync aborted
exception".

how do you think about it?   [~stack]


> Make #testWalRollOnLowReplication looser still
> ----------------------------------------------
>
>                 Key: HBASE-14600
>                 URL: https://issues.apache.org/jira/browse/HBASE-14600
>             Project: HBase
>          Issue Type: Sub-task
>          Components: test
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: 14600.addendum.txt, 14600.txt
>
>
> The parent upped timeouts on testWalRollOnLowReplication. It still fails on occasion.
Chatting w/ [~mbertozzi], he suggested that if we've make progress in the test, return the
test as compeleted successfully if we get a RuntimeException out of the sync call....(because
DN is slow to recover).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message