hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14575) Reduce scope of compactions holding region lock
Date Sat, 31 Oct 2015 07:12:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983878#comment-14983878
] 

ramkrishna.s.vasudevan commented on HBASE-14575:
------------------------------------------------

Just trying to understand the scope of this JIRA as it may be related to HBASE-13082.
Seeing the patch I can see that the region's reentrant read write lock is passed over through
out the compaction logic.
In the HRegion#compact() we can see that already we hold the read lock and it is getting released
after the compaction is over. In this patch the same lock is again passed in the further flow
and acquiring more read locks and releasing it.  May be this JIRA is not aimed at this compaction
flow whereas some other thread trying to do compaction which does not go through the HRegion.compact()?
 I may be wrong and missing something. 
Or may be this patch should remove the read lock in the HRegion.compact() and only do it where
ever needed. 

> Reduce scope of compactions holding region lock
> -----------------------------------------------
>
>                 Key: HBASE-14575
>                 URL: https://issues.apache.org/jira/browse/HBASE-14575
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction, regionserver
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 14575-v1.patch, 14575-v2.patch, 14575-v3.patch, 14575-v4.patch,
14575.v00.patch
>
>
> Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope of critical
section under which compactions hold the region read lock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message