hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14549) Simplify scanner stack reset logic
Date Wed, 07 Oct 2015 05:25:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946279#comment-14946279
] 

Lars Hofhansl commented on HBASE-14549:
---------------------------------------

Looking more at HBASE-5121, I think I do not understand what the issue is. We're recreating
the scanner heap, how can there be state left over from the prior scan. I think as soon as
I understand that, I can fix this one and make it simpler.


> Simplify scanner stack reset logic
> ----------------------------------
>
>                 Key: HBASE-14549
>                 URL: https://issues.apache.org/jira/browse/HBASE-14549
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>         Attachments: 14549-0.98.txt
>
>
> Looking at the code, I find that the logic is unnecessarily complex.
> We indicate in updateReaders that the scanner stack needs to be reset. Then almost all
store scanner (and derived classes) methods need to check and actually reset the scanner stack.
> Compaction are rare, we should reset the scanner stack in update readers, and hence avoid
needing to check in all methods.
> Patch forthcoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message