hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14531) graceful_stop.sh "if [ "$local" ]" condition unexpected behaviour
Date Thu, 01 Oct 2015 14:28:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939888#comment-14939888
] 

Hadoop QA commented on HBASE-14531:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12764583/HBASE-14531.patch
  against master branch at commit 76463a36f5648f42cdcf64019a825c1e3f0c4fe1.
  ATTACHMENT ID: 12764583

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev-support patch that doesn't require tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15841//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15841//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15841//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15841//console

This message is automatically generated.

> graceful_stop.sh "if [ "$local" ]" condition unexpected behaviour
> -----------------------------------------------------------------
>
>                 Key: HBASE-14531
>                 URL: https://issues.apache.org/jira/browse/HBASE-14531
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 2.0.0, 0.98.14, 1.0.3, 1.1.3
>            Reporter: Samir Ahmic
>            Assignee: Samir Ahmic
>         Attachments: HBASE-14531.patch
>
>
> We are using this condition to evaluate if graceful_stop.sh runs start/stop commands
on local server or remote servers. Issue is that this condition is always true and causing
unexpected behavior of script. 
> I will attach patch changing this condition to 
> {code}
> if [ "$local" = true ]
> {code}
>   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message