hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14524) Short-circuit comparison of rows in CellComparator
Date Mon, 05 Oct 2015 17:46:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943723#comment-14943723
] 

stack commented on HBASE-14524:
-------------------------------

Makes sense [~lars_francke]

This is what failed....TestBoundedByteBufferPool  it hung.... does it hang locally for you?
I think I've seen it fail elsewhere recently... so may not be you.

{code}
kalashnikov:hbase.git.commit stack$ python ./dev-support/findHangingTests.py https://builds.apache.org/job/PreCommit-HBASE-Build/15828//consoleText
Fetching https://builds.apache.org/job/PreCommit-HBASE-Build/15828//consoleText
Building remotely on H0 (Hadoop Tez) in workspace /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2
Testing patch for HBASE-14524.
Testing patch on branch master.
[INFO] Apache HBase ...................................... SUCCESS [3.100s]
[INFO] Apache HBase - Checkstyle ......................... SUCCESS [0.811s]
[INFO] Apache HBase - Resource Bundle .................... SUCCESS [0.166s]
[INFO] Apache HBase - Annotations ........................ SUCCESS [0.858s]
[INFO] Apache HBase - Protocol ........................... SUCCESS [11.488s]
[INFO] Apache HBase - Common ............................. FAILURE [1:22.510s]
[INFO] Apache HBase - Procedure .......................... SKIPPED
[INFO] Apache HBase - Client ............................. SKIPPED
[INFO] Apache HBase - Hadoop Compatibility ............... SKIPPED
[INFO] Apache HBase - Hadoop Two Compatibility ........... SKIPPED
[INFO] Apache HBase - Prefix Tree ........................ SKIPPED
[INFO] Apache HBase - Server ............................. SKIPPED
[INFO] Apache HBase - Testing Util ....................... SKIPPED
[INFO] Apache HBase - Thrift ............................. SKIPPED
[INFO] Apache HBase - Shell .............................. SKIPPED
[INFO] Apache HBase - Integration Tests .................. SKIPPED
[INFO] Apache HBase - Examples ........................... SKIPPED
[INFO] Apache HBase - Rest ............................... SKIPPED
[INFO] Apache HBase - External Block Cache ............... SKIPPED
[INFO] Apache HBase - Assembly ........................... SKIPPED
[INFO] Apache HBase - Shaded ............................. SKIPPED
[INFO] Apache HBase - Shaded - Client .................... SKIPPED
[INFO] Apache HBase - Shaded - Server .................... SKIPPED
[INFO] Apache HBase - Spark .............................. SKIPPED
Printing hanging tests
Hanging test : org.apache.hadoop.hbase.io.TestBoundedByteBufferPool
Printing Failing tests
{code}

> Short-circuit comparison of rows in CellComparator
> --------------------------------------------------
>
>                 Key: HBASE-14524
>                 URL: https://issues.apache.org/jira/browse/HBASE-14524
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HBASE-14524.patch
>
>
> {{CellComparator#compareRows}} compares two rows. For Scans and Gets these objects can
sometimes be exactly the same object.
> I see this (without fully understanding everything that's going on) for the first cell
in each row.
> In these circumstances I think it makes sense to short-circuit the comparison (not do
a byte comparison and class cast checks) and bail out early if the objects are identical.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message