hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Singhi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14491) ReplicationSource#countDistinctRowKeys code logic is not correct
Date Wed, 14 Oct 2015 02:25:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956151#comment-14956151
] 

Ashish Singhi commented on HBASE-14491:
---------------------------------------

Thanks for the explanation, [~enis].
bq. WALEdit sharing the same row key, but they are still distinct mutations that has to be
counted separately
I feel the better method name should have been countDistinctMutations than countDistinctRowKeys.
Anyways I will close this.

> ReplicationSource#countDistinctRowKeys code logic is not correct
> ----------------------------------------------------------------
>
>                 Key: HBASE-14491
>                 URL: https://issues.apache.org/jira/browse/HBASE-14491
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>            Priority: Minor
>
> {code}
>       Cell lastCell = cells.get(0);
>       for (int i = 0; i < edit.size(); i++) {
>         if (!CellUtil.matchingRow(cells.get(i), lastCell)) {
>           distinctRowKeys++;
>         }
>       }
> {code}
> The above logic for finding the distinct row keys in the list needs to be corrected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message