hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14491) ReplicationSource#countDistinctRowKeys code logic is not correct
Date Tue, 13 Oct 2015 18:39:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955439#comment-14955439
] 

Andrew Purtell commented on HBASE-14491:
----------------------------------------

bq. As for sorting, if cells within WAL edits are not sorted, we should NOT sort them or allocate
a new set to do the counting. distinctRowKeys is only used for the metric replicatedOperations
and it will be expensive to allocate new objects just for this metric.

Agreed, I'd prefer we drop the metric.

> ReplicationSource#countDistinctRowKeys code logic is not correct
> ----------------------------------------------------------------
>
>                 Key: HBASE-14491
>                 URL: https://issues.apache.org/jira/browse/HBASE-14491
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>            Priority: Minor
>
> {code}
>       Cell lastCell = cells.get(0);
>       for (int i = 0; i < edit.size(); i++) {
>         if (!CellUtil.matchingRow(cells.get(i), lastCell)) {
>           distinctRowKeys++;
>         }
>       }
> {code}
> The above logic for finding the distinct row keys in the list needs to be corrected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message