hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zephyr Guo (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-14490) [RpcServer] reuse request read buffer
Date Thu, 08 Oct 2015 15:06:28 GMT

     [ https://issues.apache.org/jira/browse/HBASE-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Zephyr Guo updated HBASE-14490:
-------------------------------
    Description: 
Reuse buffer to read request.It's not necessary to every request free buffer.The idea of optimization
is to reduce the times that allocate ByteBuffer.

*Modification*
1. {{saslReadAndProcess}} ,{{processOneRpc}}, {{processUnwrappedData}} accept a ByteBuffer
instead of byte[].They can move {{ByteBuffer.position}} correctly when we have read the data.

2. {{processUnwrappedData}} no longer use any extra memory.

3. Maintaining a reused ByteBuffer in each {{Connection}}.
a) Size is dynamic to fit specific client.
b) If size deviate far from average size, we replace a new one.
c) Using a SoftReference to reference the buffer.



  was:
Reuse buffer to read request.It's not necessary free data's buffer for each request.Optimization
is to reduce the times that allocate ByteBuffer.

*patch modification*

* {{saslReadAndProcess}} and {{processOneRpc}} accept a ByteBuffer instead of byte[].

* {{processUnwrappedData}} can reuse the same ByteBuffer that {{saslReadAndProcess}} used.

* Maintaining a reused ByteBuffer each {{Connection}} for small request.
** Buffer size is fixed.
** Using a SoftReference to reference the buffer.
** If request is too large, we allocate a temporary ByteBuffer.Freeing it when  {{process()}}
will have been finished.




> [RpcServer] reuse request read buffer
> -------------------------------------
>
>                 Key: HBASE-14490
>                 URL: https://issues.apache.org/jira/browse/HBASE-14490
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC
>    Affects Versions: 2.0.0, 1.0.2
>            Reporter: Zephyr Guo
>            Assignee: Zephyr Guo
>              Labels: performance
>             Fix For: 2.0.0, 1.0.2
>
>         Attachments: ByteBufferPool.java, HBASE-14490-v1.patch, HBASE-14490-v10.patch,
HBASE-14490-v11.patch, HBASE-14490-v2.patch, HBASE-14490-v3.patch, HBASE-14490-v4.patch, HBASE-14490-v5.patch,
HBASE-14490-v6.patch, HBASE-14490-v7.patch, HBASE-14490-v8.patch, HBASE-14490-v9.patch
>
>
> Reuse buffer to read request.It's not necessary to every request free buffer.The idea
of optimization is to reduce the times that allocate ByteBuffer.
> *Modification*
> 1. {{saslReadAndProcess}} ,{{processOneRpc}}, {{processUnwrappedData}} accept a ByteBuffer
instead of byte[].They can move {{ByteBuffer.position}} correctly when we have read the data.
> 2. {{processUnwrappedData}} no longer use any extra memory.
> 3. Maintaining a reused ByteBuffer in each {{Connection}}.
> a) Size is dynamic to fit specific client.
> b) If size deviate far from average size, we replace a new one.
> c) Using a SoftReference to reference the buffer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message