hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14427) Fix 'should' assertions in TestFastFail
Date Wed, 21 Oct 2015 11:28:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966659#comment-14966659
] 

Hadoop QA commented on HBASE-14427:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12767737/HBASE-14427.patch
  against master branch at commit 6e3b7af0efced7351163a5011a44bfc18851fce0.
  ATTACHMENT ID: 12767737

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number
of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16137//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16137//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16137//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16137//console

This message is automatically generated.

> Fix 'should' assertions in TestFastFail
> ---------------------------------------
>
>                 Key: HBASE-14427
>                 URL: https://issues.apache.org/jira/browse/HBASE-14427
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: stack
>            Priority: Minor
>              Labels: beginner
>         Attachments: HBASE-14427.patch
>
>
> Over in HBASE-14421, TestFastFail has been failing assertions that talk of events that
'should' be happening. Fix. For now HBASE-14421 has disabled the 'should' assertions. They
seem fine on apache jenkins build but fail fairly reliably for me on alternate HW.
> To address, get familiar with the test. Change the commented out asserts to be yes/no
instead of a 'likely' (On a cursory scan, it is possible that a test run may not involve preemption
and it is these runs that are throwing asserts).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message